<html>
<head><meta charset="utf-8"><title>tidy · rustdoc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/index.html">rustdoc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html">tidy</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="217982732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/217982732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#217982732">(Nov 26 2020 at 09:53)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> Btw: I installed tidy and I have a huge issue with the output: it's super cool because it displays exactly the diff between the two HTMLs, but then it displays ALL the HTML (which is a bit problematic). Would it be possible to only keep the (small) diffs?</p>



<a name="218002393"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218002393" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218002393">(Nov 26 2020 at 13:38)</a>:</h4>
<p><span class="user-mention" data-user-id="210316">@GuillaumeGomez</span> it should only be showing the diff now - can you post a screenshot?</p>



<a name="218002657"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218002657" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218002657">(Nov 26 2020 at 13:42)</a>:</h4>
<p>Not really since it litterally shows ALL the HTML</p>



<a name="218002708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218002708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218002708">(Nov 26 2020 at 13:42)</a>:</h4>
<p>so my terminal is completely full</p>



<a name="218002713"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218002713" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218002713">(Nov 26 2020 at 13:42)</a>:</h4>
<p>a screenshot wouldn't help much haha</p>



<a name="218003803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218003803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218003803">(Nov 26 2020 at 13:52)</a>:</h4>
<p>I'm really confused :/ which test is this for?</p>



<a name="218004165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004165">(Nov 26 2020 at 13:56)</a>:</h4>
<div class="codehilite"><pre><span></span><code>./x.py test src/test/rustdoc --stage 1 --jobs 2
</code></pre></div>



<a name="218004211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004211">(Nov 26 2020 at 13:56)</a>:</h4>
<p>right, yes, but which tests are failing?</p>



<a name="218004258"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004258" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004258">(Nov 26 2020 at 13:57)</a>:</h4>
<p>Nothing is failing, I was testing out the tidy output by making on purpose a failing change haha</p>



<a name="218004289"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004289" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004289">(Nov 26 2020 at 13:57)</a>:</h4>
<p>and even though the specific diff lines are great, the rest is just waaaaaaaaaaaaaaaay too much</p>



<a name="218004308"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004308" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004308">(Nov 26 2020 at 13:57)</a>:</h4>
<p>I am still not clear what changes you're asking for.</p>



<a name="218004374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004374">(Nov 26 2020 at 13:58)</a>:</h4>
<p>can you post what it looks like now, and maybe a mockup of what you'd like it to be?</p>



<a name="218004532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004532">(Nov 26 2020 at 13:59)</a>:</h4>
<p>I'll create the file by redirecting output then</p>



<a name="218004596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004596">(Nov 26 2020 at 14:00)</a>:</h4>
<p>but it'll be huge</p>



<a name="218004604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218004604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218004604">(Nov 26 2020 at 14:00)</a>:</h4>
<p>sure, that's fine - thanks!</p>



<a name="218007923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218007923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218007923">(Nov 26 2020 at 14:30)</a>:</h4>
<p><span class="user-mention" data-user-id="210316">@GuillaumeGomez</span> ok I found the issue - there was a change in <code>ayu.css</code> and it wasn't formatted by tidy so it showed the whole file</p>



<a name="218007946"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218007946" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218007946">(Nov 26 2020 at 14:31)</a>:</h4>
<p>I think the best solution is to ignore .css and .js files in the diff, since they're never autogenerated</p>



<a name="218008079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008079">(Nov 26 2020 at 14:32)</a>:</h4>
<p>in the short term I think it will be fixed with <code>rustup default nightly</code>, since that will compare to a version of rustdoc that has the same CSS output</p>



<a name="218008174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008174">(Nov 26 2020 at 14:33)</a>:</h4>
<p>Still remain highly not efficient. I was afraid of such issues, but I see that as the first step before big improvements. For the time being, I'll just not use tidy I guess</p>



<a name="218008260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008260">(Nov 26 2020 at 14:34)</a>:</h4>
<p>getting rid of tidy won't help, it will still generate a diff</p>



<a name="218008273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008273">(Nov 26 2020 at 14:34)</a>:</h4>
<p>I'll make a PR ignoring .css files</p>



<a name="218008309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008309">(Nov 26 2020 at 14:34)</a>:</h4>
<p>Well, at least I won't have the whole HTML in my terminal haha</p>



<a name="218008320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008320">(Nov 26 2020 at 14:34)</a>:</h4>
<p>no, you still will :P</p>



<a name="218008345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008345">(Nov 26 2020 at 14:35)</a>:</h4>
<p>unless you don't have a local <code>rustdoc</code> at all</p>



<a name="218008504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218008504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218008504">(Nov 26 2020 at 14:36)</a>:</h4>
<p>err actually that's waiting on <a href="https://github.com/rust-lang/rust/pull/79370">https://github.com/rust-lang/rust/pull/79370</a></p>



<a name="218036511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218036511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218036511">(Nov 26 2020 at 20:35)</a>:</h4>
<blockquote>
<p>I installed tidy</p>
</blockquote>
<p>What does that mean? Do you meant tidy as in <code>./x.py test tidy</code>? I'm curious to see what this tool is :)</p>



<a name="218036529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218036529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218036529">(Nov 26 2020 at 20:35)</a>:</h4>
<p>No, I mean the <code>tidy</code> binary haha</p>



<a name="218036576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218036576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218036576">(Nov 26 2020 at 20:36)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> made a PR recently to improve the output of errors when running <code>x.py test src/test/rustdoc</code></p>



<a name="218036578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218036578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218036578">(Nov 26 2020 at 20:36)</a>:</h4>
<p>and that improvement uses the <code>tidy</code> binary</p>



<a name="218036582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218036582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218036582">(Nov 26 2020 at 20:36)</a>:</h4>
<p>so not linked ;)</p>



<a name="218039590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218039590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218039590">(Nov 26 2020 at 21:27)</a>:</h4>
<p>Ah, were you referring to <a href="https://github.com/htacg/tidy-html5">this project</a>?</p>



<a name="218045624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/218045624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#218045624">(Nov 26 2020 at 23:42)</a>:</h4>
<p>Yes, that's it.</p>



<a name="219709478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/219709478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#219709478">(Dec 12 2020 at 13:40)</a>:</h4>
<p>fyi <span class="user-mention" data-user-id="210316">@GuillaumeGomez</span> <a href="https://github.com/rust-lang/rust/pull/79370">https://github.com/rust-lang/rust/pull/79370</a> has been waiting on review a while</p>



<a name="219710817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/219710817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#219710817">(Dec 12 2020 at 14:18)</a>:</h4>
<p>Arf! I thought it was waiting on Mark XD</p>



<a name="219710820"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/tidy/near/219710820" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/tidy.html#219710820">(Dec 12 2020 at 14:18)</a>:</h4>
<p>taking a look then!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>